your lattice vectors are correct. Note that there are infinitely many valid sets of primitive lattice vectors. See also this post Writing the basis - #4 by t.vandersar. Also, the solutions of the warm-up exercises Crystal structure - Open Solid State Notes describe the fcc and bcc lattices